Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed VLA definition because not every compiler supports that #326

Conversation

atvise
Copy link
Contributor

@atvise atvise commented Apr 14, 2017

No description provided.

@weltling
Copy link

weltling commented Jul 1, 2017

Fair enough, support for VLA on is not certain. Leaving aside Visual Studio, rare platforms could be hurt.

Thanks.

@carlos-granados
Copy link

This has been merged into a maintained fork here fast-debug#2

@robocoder
Copy link
Contributor

#424 duplicates #326 but takes a different approach to address the lack of VLA support in MSVC.

Can we pick one approach and use a wrapper, e.g.,?

#if __STDC_NO_VLA__
        zval* arguments = static_cast<zval*>(alloca(argc * sizeof(zval)));
#else
        zval arguments[argc];
#endif

@EmielBruijntjes EmielBruijntjes merged commit d778788 into CopernicaMarketingSoftware:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants