Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globalfix #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Globalfix #385

wants to merge 2 commits into from

Conversation

Cxarli
Copy link

@Cxarli Cxarli commented Jul 25, 2018

The Globals example failed on the Php::GLOBALS["c"]["member"] part. This PR should fix that issue, and adds another example which shows what the bug was.

Copy link
Contributor

@robocoder robocoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In global.h, instead of adding force_update(), why not simply mark it as dirty (by clearing the _exists flag) and then call the existing update()?

Example:

    _exists = false;
    update();

    Value::set(index, value);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants