Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes Globals example where Php::GLOBALS["c"]["member"] is not set #516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes Globals example where Php::GLOBALS["c"]["member"] is not set #516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions include/global.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ class PHPCPP_EXPORT Global : public Value
Global &operator=(const T &value)
{
Value::operator=(value);

return update();
}

Expand All @@ -109,11 +110,12 @@ class PHPCPP_EXPORT Global : public Value
*/
virtual void set(int index, const Value &value) override
{
// update current object
update();

// call base
Value::set(index, value);

// update current object
_exists = false;
update();
}

/**
Expand All @@ -126,11 +128,12 @@ class PHPCPP_EXPORT Global : public Value
*/
virtual void set(const char *key, int size, const Value &value) override
{
// update current object
update();

// call base
Value::set(key, size, value);

// update current object
_exists = false;
update();
}


Expand Down