Fix memory corruption #530
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't expect this to be merged as quickly as the last MR I sent in. However, just in case, don't merge this yet. Everything seems to work properly except for when trying to use Reflection on these classes. I'm investigating the root cause of that now. |
|
I think this is safe to merge. The crash I'm seeing also happens with PHP 8.1 and I've isolated the issue and will file an issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initializing a function parameter that takes a class as an argument in some situations the name of the class is incorrect and points to other memory. Thus we copy the class name into its own zend_string first.