Skip to content

fix(notes): proper default settings when resetting state #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

CorentinTh
Copy link
Owner

Closes #433

@CorentinTh CorentinTh requested a review from Copilot July 22, 2025 19:09
@CorentinTh CorentinTh self-assigned this Jul 22, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the state reset functionality in the create note page to use proper default settings from configuration instead of hardcoded values. The change ensures that when the note creation form is reset, it applies the application's configured default settings rather than arbitrary fixed values.

  • Replaces hardcoded TTL and delete-after-reading values with configuration-based defaults
  • Adds missing reset of the hasNoExpiration setting to its configured default value

Copy link

Copy link

github-actions bot commented Jul 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed-docs ✅ Ready (View Log) Visit Preview fe5650b

Copy link

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
enclosed 🔨 Building (View Log) fe5650b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When clicking "New note" button, the default delay and delete settings aren't honored.
1 participant