Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added get dashboard #20

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added get dashboard #20

wants to merge 2 commits into from

Conversation

tuhinmallick
Copy link
Collaborator

No description provided.

@tuhinmallick tuhinmallick self-assigned this Dec 17, 2022
@tuhinmallick tuhinmallick linked an issue Dec 17, 2022 that may be closed by this pull request
@tuhinmallick
Copy link
Collaborator Author

I will pull in the new changes from #21 and then do a PR

@tuhinmallick tuhinmallick marked this pull request as draft December 18, 2022 11:41
@tuhinmallick tuhinmallick marked this pull request as ready for review December 19, 2022 20:15
@tuhinmallick
Copy link
Collaborator Author

@KonradUdoHannes Done merging the changes of #21

@KonradUdoHannes
Copy link
Collaborator

I'm still not sure whether we actually need dashboard in the client, but I think we can still use the PR to address a weakness in our project setup. Right now we potentially get a whole bunch of tiny issues from formatting, linting and line ending when merging our different PRs. At the same time these issues are hardly worth discussing by themselves. In order to avoid them in the first place I introduced pre-commit hooks (already merged in main). These will ensure that every commit automatically passes certain requirements (and they also help fix a lot of the issues).

I would suggest that you bring the branch up to date with main and the try to set up pre-commit as described in the readme. Generally this is a very useful tool, not just for R but also for a lot of other programming languages. Let me know if there is any trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Dashboard functionality
2 participants