[v17] feat!: FeeShare allow DAODAO to register contracts#758
[v17] feat!: FeeShare allow DAODAO to register contracts#758reecepbcups merged 7 commits intomainfrom
Conversation
dimiandre
left a comment
There was a problem hiding this comment.
How disk space will be affected?
I can imagine majority of the contracts calls transactions will be with feeshare payout event attached
|
@dimiandre for the event emit? basically nothing relative to the size/compute of CW executes I will benchmark the gas cost difference tomorrow, but I expect it to be <500 gas if even |
|
@dimiandre So no gas changes. The string is ~200bytes, so cost <5MB every 25mil contract calls WITH feeshare enabled + any CosmosSDK indexing overhead, but small in comparison |
Closes #593
Cleanups up some logic + adds test.