reduce tokens in targetsupply when burning#816
Merged
reecepbcups merged 2 commits intoreece/burn-without-mintfrom Sep 1, 2023
Merged
reduce tokens in targetsupply when burning#816reecepbcups merged 2 commits intoreece/burn-without-mintfrom
reecepbcups merged 2 commits intoreece/burn-without-mintfrom
Conversation
Contributor
|
Thanks! This looks good to me. Something with modifying Mint/Burn in both branches seems to break the Unity prop. So ill fix that in the other branch & add a Burn contract tester |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr is targeting reece branch
maxSupply is actually reduced way more than the burned coins, because maxsupply is calculated dynamically at each 1 year epoch based on inflation schedule
this table estimates how much the max supply will be impacted for a burn in each phase schedule