Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce tokens in targetsupply when burning #816

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

dimiandre
Copy link
Member

this pr is targeting reece branch

  • This way the bank.totalSupply will always be right
  • By reducing target supply, we reduce also the maxSupply and we shorten the halving date

maxSupply is actually reduced way more than the burned coins, because maxsupply is calculated dynamically at each 1 year epoch based on inflation schedule

this table estimates how much the max supply will be impacted for a burn in each phase schedule

Year Burn Amount Effective Max Supply reduction
2 1 JUNO 2.04 JUNO
3 1 JUNO 1.70 JUNO
4 1 JUNO 1.54 JUNO
5 1 JUNO 1.41 JUNO
6 1 JUNO 1.31 JUNO
7 1 JUNO 1.22 JUNO
8 1 JUNO 1.15 JUNO
9 1 JUNO 1.10 JUNO
10 1 JUNO 1.06 JUNO
11 1 JUNO 1.03 JUNO
12 1 JUNO 1.00 JUNO

@Reecepbcups
Copy link
Contributor

Thanks! This looks good to me. Something with modifying Mint/Burn in both branches seems to break the Unity prop. So ill fix that in the other branch & add a Burn contract tester

@Reecepbcups Reecepbcups merged commit 9c7ec82 into reece/burn-without-mint Sep 1, 2023
18 of 19 checks passed
@joelsmith-2019 joelsmith-2019 deleted the dimi/burn-targetsupply branch February 2, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants