Redesign EditProfilePage and EditHostingPreferences #6494
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
These are big improvements! Looks a lot more professional/modern and better organized. Most of my suggestions are related to rewording or adding a link. I like the style changes to the hosting/meet up selectors recently made. I thought maybe adding a stroke like this could help (but do what you think looks best):
https://github.com/user-attachments/assets/0c9de973-bd7f-4a52-86eb-6304857bc930
In the hosting status section, the text I'm available to host travelers and provide accommodation might suggest some sense of obligation to people and "provide accomodation" sounds too much like airbnb etc. This status is more for indicating eagerness (compared to just willingness), so I think we should use the following text instead:
I am eager to let people stay with me!
This sentence is missing "the" isn't it?: I might be able to host, depending on circumstances
Shouldn't it be: I might be able to host, depending on the circumstances?
Similarly, I think the meetup texts should be:
- Wants to meet:
I'm eager to meet up with travelers - Wants to meet:
I might meet up, depending on the circumstances - Can't meet up:
I prefer not to meet up with travelers
The "About me" hint This content is visible by other users when they search for you. should read:
The beginning of this section is visible in search results when other members search for you
Also, the footer should be removed from this page. It's not needed on this page, and in some cases it causes users to overlook the save button (especially on high resolution desktop and on big mobile devices).
nabramow
changed the title
…into na/web/new-edit-profile-design
There was a problem hiding this comment.
Changes look good! A couple more things I found:
Regarding the below screenshot:
Instead of the MUI icon Search we should use InfoOutline instead to avoid confusion.
I couldn't find the text Please write 150 more characters to complete your profile. in the files, but this should probably be changed to on of the following, either:
You must write at least 150 characters in order to interact with other people on the platform.
OR
**Please write at least 150 characters to unlock messaging and requests.** Genuine profiles build a community of trust. The more you share, the easier it is to connect!
In the photo upload section, we should show the following text by default:
**A photo of yourself is required to interact with the community.** A clear, friendly photo showing your face builds trust, helps others feel comfortable, and greatly improves your chances of receiving a response.
I suggest we move the "Start by providing..." text above the green separator line below "Basic information", and then below the green separator line put the new photo text mentioned above.
| "preferences_subtitle": "Let others know about your hosting and meetup preferences", | ||
| "personal_information": "Personal Information", | ||
| "personal_information_subtitle": "Share details about yourself and your background", | ||
| "about_me_subtitle": "Tell others about yourself. This is where trust begins. Help others get a sense of who you really are. See <1>tips for creating a great profile</1>.", |
There was a problem hiding this comment.
Looks like the link isn't working here:
|
Okay @jesseallhands I addressed all of this, except I did the location for the profile photo description differently.
Also just checking you looked at the "My Home" page too as so far all your comments were about the first tab! Unless it's perfect ;-). |
Oops yeah I need to look at that still! 😅 |
There was a problem hiding this comment.
Sorry for overlooking the "My home" section the first time around! Here are the things I found on that page:
-
If you empty the "max number of guests" field, and click submit, you get an "assertion failed error:
This field should probably just be a dropdown menu. This works well because the vast majority of the numbers selected will be between 1-5, and it will be rare that someone would enter a number >10. Alternatively, a number input toggle (like this MUI component) could work since the vast majority of inputs will be 1-5. -
Some fields that should require the user to actively make a selection currently seem to default to a selection. For example, "sleeping privacy" defaults to "private space". Furthermore "ask me" was meant to be a placeholder only for "null" values leftover from the alpha version. "ask me" shouldn't be an option we offer to new users.
Here are the fields that shouldn't have a default (user should be forced to make a selection): - Okay with smoking (this is a quite important factor for health/comfort)
- Sleeping privacy
- Parking details (if parking available checkbox is activated)
These required fields will need a modal error message if the user tries to save when they are empty. The modal should say:Oops! You missed some required fields. Please complete them before saving.orPlease fill in all required fields before saving.
- The following options should be displayed differently to avoid ambiguity (eg. the children part, legal yikes 😅):
Hosts children-->Hosts people with childrenHosts pets-->Hosts people with petsOkay with drinking-->Okay with people drinking
- The
Let guests know what you're comfortable withsection has some options that don't really fit with the rest of the options. For example:
- Wheelchair accessible
- Tent camping available
These two options have nothing to do with what you're comfortable with - but instead what your home facilities are able to accommodate. Therefore, the following options should be moved to the Household Details section, and probably in the following order after the Household Members subsection:
- Wheelchair accessible
- Tent camping available
- Parking available
- Parking details (only display if
parking availableis activated)
- Parking details (only display if
| "household_habits": "Household Habits", | ||
| "hosting_preferences_subtitle": "Let guests know what you're comfortable with", | ||
| "about_home_subtitle": "Tell guests about your home and what they can expect", | ||
| "household_details_subtitle": "Share information about who lives in your home", |
There was a problem hiding this comment.
| "household_details_subtitle": "Share information about who lives in your home", | |
| "household_details_subtitle": "Share more details about your household", |
Describe briefly what this PR is doing and why
Redesign of the EditProfile and EditHostingPreference pages to be more organized, provide more guidance and fix some longstanding issues.
Closes #6360
Closes #6459
Closes #6517
Please give clear steps for how the reviewer can best test this PR
Please include any necessary dev environment, .env, etc. adjustments.
Web frontend checklist
yarn formatyarn lint --fixOther
Untick the following if you'd prefer that maintainers don't push commits/merge your branch.