Bugfix/cleanup whitespace #881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gittiver
previously approved these changes
Aug 31, 2024
|
Seems like this breaks something i will look into it. |
fliiiix
force-pushed
the
bugfix/cleanup-whitespace
branch
from
3a95da4 to
7b3135b
Compare
gittiver
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project im integrating crow in has relatively strict rules to trailing whitespace.
Because of that i went through all the files and remove whitespace issues.
For code and config i don't really see a risk of that breaking something as these are all non whitespace sensitive.
The biggest risk is in docs markdown files as it is whitespace sensitive. I think it makes most sense to review this closely.
I did my best to make sure it should still produce the same output.