Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGC API - Features - Part 4: Create #127

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

benoitdm-oslandia
Copy link
Collaborator

@benoitdm-oslandia benoitdm-oslandia commented Oct 6, 2022

implements CREATE feature from OGC API - Features - Part 4

DELETE UPDATE REPLACE will come in separated PR.

This is the simplest version without optimistic locking.

@dr-jts dr-jts added the enhancement New feature or request label Oct 6, 2022
@dr-jts
Copy link
Collaborator

dr-jts commented Oct 6, 2022

Because this PR opens the door to changing server data, I think it needs a way to control if it is enabled (and the default must be disabled, since otherwise this exposes existing installations to change). Of course, database security can be used to do this as well, but it is sometimes convenient to control this via configuration (and that is essential to avoid changing current behaviour).

This could be done via a configuration parameter. The simplest thing would be a single parameter (say [Database] EnableWrite = true with default false.

It might be nice to allow finer-grained control over which tables can be changed as well. This could be done via additional config parameters similar to the current TableIncludes and TableExcludes.

@benoitdm-oslandia
Copy link
Collaborator Author

Adding an option to enable/disable the write access is a good idea. We will bring a fix asap. But the table filtering will be done in a separated PR.

@benoitdm-oslandia benoitdm-oslandia force-pushed the gh/feat/add_create_schema branch 2 times, most recently from a81e09e to 5fe8feb Compare October 12, 2022 06:14
@Guts
Copy link

Guts commented Jan 16, 2023

Hello @dr-jts,

Any chance to see this one merged or reviewed again in next days?

Thanks!

internal/data/db_sql.go Outdated Show resolved Hide resolved
internal/data/db_sql.go Outdated Show resolved Hide resolved
@dr-jts
Copy link
Collaborator

dr-jts commented Jan 17, 2023

What is the extent of support for Coordinate Reference Systems?

I see the following levels of capability (feel free to amend):

  1. Data in geodetic, target table in geodetic CRS (no reprojection)
  2. Data in non-geodetic CRS (implicit), target table has same CRS (no reprojection;
  3. Data in geodetic, target table with any CRS (reprojection potentially required)
  4. Data in non-geodetic CRS (explicit in GeoJSON), table in different CRS (reprojection potentially required)

This is the kind of non-obvious functionality which needs to be documented for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants