Support file_size_bytes option #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/file-size-bytes
branch
from
974c773 to
db443bb
Compare
aykut-bozkurt
force-pushed
the
aykut/cache-object-stores
branch
from
9d90243 to
a493016
Compare
aykut-bozkurt
force-pushed
the
aykut/file-size-bytes
branch
from
db443bb to
3bd4f41
Compare
aykut-bozkurt
force-pushed
the
aykut/file-size-bytes
branch
2 times, most recently
from
6428599 to
a857cb6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
==========================================
+ Coverage 91.88% 92.45% +0.56%
==========================================
Files 77 78 +1
Lines 10320 10640 +320
==========================================
+ Hits 9483 9837 +354
+ Misses 837 803 -34 ☔ View full report in Codecov by Sentry. |
aykut-bozkurt
commented
Jan 30, 2025
| @@ -1194,8 +1194,6 @@ mod tests { | |||
| results | |||
| }); | |||
|
|
|||
| Spi::run("TRUNCATE dog_owners;").unwrap(); | |||
There was a problem hiding this comment.
fix a wrong flow that revealed by the PR
COPY TO parquet now supports a new option, called `file_size_bytes`, which lets you generate parquet files with target size = `file_size_bytes`. When a parquet file exceeds the target size, it will be flushed and a new parquet file will be generated under a parent directory. (parent directory will be the path without the parquet extension) e.g. ```sql COPY (select 'hellooooo' || i from generate_series(1, 1000000) i) to '/tmp/test.parquet' with (file_size_bytes 1048576); ``` ```bash > ls -alh /tmp/test/ 1.4M data_0.parquet 1.4M data_1.parquet 1.4M data_2.parquet 1.4M data_3.parquet 114K data_4.parquet ```
aykut-bozkurt
force-pushed
the
aykut/file-size-bytes
branch
from
a857cb6 to
2c06724
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COPY TO parquet now supports a new option, called
file_size_bytes, which lets you generate parquet files with target size =file_size_bytes.When a parquet file exceeds the target size, it will be flushed and a new parquet file will be generated under a parent directory. (parent directory will be the path without the parquet extension)
e.g.
> ls -alh /tmp/test/ 1.4M data_0.parquet 1.4M data_1.parquet 1.4M data_2.parquet 1.4M data_3.parquet 114K data_4.parquet