Skip to content

Speed up instantiation of Gaston with Theta component #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Speed up instantiation of Gaston with Theta component #326

wants to merge 1 commit into from

Conversation

p-huynh
Copy link
Collaborator

@p-huynh p-huynh commented May 16, 2025

This PR adds caching for the binary_matrix in the ThetaGaston component to avoid redundant computation:

  • Matrix is cached in memory and on disk under claasp/ciphers/permutations/{cipher_id}.pkl.
  • Matrix is only computed if not already cached.

This improves performance when the same cipher configuration is used multiple times.

@p-huynh p-huynh requested a review from peacker May 16, 2025 06:37
@p-huynh p-huynh closed this May 16, 2025
@p-huynh p-huynh reopened this May 16, 2025
@p-huynh p-huynh changed the base branch from main to develop May 16, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peacker peacker Awaiting requested review from peacker

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@p-huynh