-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adhoc changes #1672
adhoc changes #1672
Conversation
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
Signed-off-by: Prabhu Subramanian <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @prabhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request includes several ad-hoc changes. It adds cocoapods to the container images, includes thought logs for cocoapods, and improves line numbers reported, addressing issue #1670. The changes span across multiple Dockerfiles to include cocoapods, updates dependency versions in deno.json
, modifies logic in lib/cli/index.js
to handle multiple pod files and exclude targets, adjusts line number reporting in lib/evinser/evinser.js
, adds a tip for swift projects in lib/evinser/swiftsem.js
, modifies relative directory conversion in lib/stages/postgen/postgen.js
, and updates package versions in package.json
and pnpm-lock.yaml
.
Highlights
- Cocoapods Integration: Cocoapods is added to multiple Dockerfiles (ci/Dockerfile, ci/Dockerfile-bun, ci/Dockerfile-deno, ci/Dockerfile-ppc64, ci/Dockerfile-secure, ci/base-images/debian/Dockerfile.ruby33, ci/base-images/debian/Dockerfile.ruby34) to include cocoapods in the container images.
- Dependency Updates: The pull request updates the versions of
@appthreat/atom
andsequelize
indeno.json
andpackage.json
, along with corresponding updates inpnpm-lock.yaml
. - Cocoapods Handling Improvements: Enhancements in
lib/cli/index.js
to handle multiple pod files and exclude specified targets during the SBOM generation process. - Line Number Reporting: The pull request improves line number reporting in
lib/evinser/evinser.js
, specifically for Java and JAR files, to address issue Occurrence line numbers are off #1670. - Swift Project Support: Adds a tip in
lib/evinser/swiftsem.js
to guide users on troubleshooting Swift project builds, especially regarding xcodebuild support. - Relative Directory Conversion: Modifies the relative directory conversion logic in
lib/stages/postgen/postgen.js
to avoid arbitrary relativization for unrelated directories.
Changelog
Click here to see the changelog
- ci/Dockerfile
- Added cocoapods to the gem install command.
- ci/Dockerfile-bun
- Added cocoapods to the gem install command.
- ci/Dockerfile-deno
- Added cocoapods to the gem install command.
- ci/Dockerfile-ppc64
- Added cocoapods to the gem install command.
- ci/Dockerfile-secure
- Added cocoapods to the gem install command.
- ci/base-images/debian/Dockerfile.ruby33
- Added cocoapods to the gem install command.
- ci/base-images/debian/Dockerfile.ruby34
- Added cocoapods to the gem install command.
- deno.json
- Updated version to 11.2.1
- Updated @appthreat/atom dependency to 2.1.13
- Updated sequelize dependency to 6.37.6
- lib/cli/index.js
- Added thought logs for cocoapods processing.
- Improved handling of multiple pod files.
- Added logic to exclude certain targets from CocoaPods projects.
- lib/evinser/evinser.js
- Improved line number reporting for Java and JAR files.
- lib/evinser/swiftsem.js
- Added a tip for troubleshooting Swift project builds.
- lib/helpers/utils.js
- Modified executePodCommand to use POD_CMD environment variable and provide more informative error messages.
- Added null check to podspec parsing to prevent errors.
- Added cocoa project type alias
- lib/stages/postgen/postgen.js
- Modified relative directory conversion to avoid arbitrary relativization.
- package.json
- Updated version to 11.2.1
- Updated @appthreat/atom dependency to 2.1.13
- Updated sequelize dependency to 6.37.6
- Updated typescript dependency to 5.8.2
- pnpm-lock.yaml
- Updated multiple dependencies to their latest versions.
- types/lib/cli/index.d.ts
- Added function declaration for createCocoaBom.
- types/lib/evinser/swiftsem.d.ts
- Updated swiftsem.d.ts mappings
- types/lib/helpers/utils.d.ts
- Added function declarations for cocoa pods related functions
- Added cocoa project type alias
- types/lib/stages/postgen/postgen.d.ts
- Updated postgen.d.ts mappings
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The .jar file extension stands for Java ARchive.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Warning Gemini encountered an error creating the review. You can try again by commenting |
* Update atom. Include cocoapods gem. Signed-off-by: Prabhu Subramanian <[email protected]> * Added thought logs for cocoapods Signed-off-by: Prabhu Subramanian <[email protected]> * Added thought logs for cocoapods Signed-off-by: Prabhu Subramanian <[email protected]> --------- Signed-off-by: Prabhu Subramanian <[email protected]> Signed-off-by: emcfins <[email protected]>
Added some thought logs for cocoapods. Adds cocoapods to the container images.
Improves line numbers reported under #1670