Populate url when processing license expressions#999
Open
giovanni-bozzano wants to merge 1 commit intoCycloneDX:masterfrom
Open
Populate url when processing license expressions#999giovanni-bozzano wants to merge 1 commit intoCycloneDX:masterfrom
giovanni-bozzano wants to merge 1 commit intoCycloneDX:masterfrom
Conversation
Signed-off-by: Giovanni Bozzano <giovanni.bozzano@traceone.com>
giovanni-bozzano
force-pushed
the
master
branch
from
c7c70c8 to
0c02c28
Compare
Contributor
|
We would need exactly this. Could this be merged as it's just a one-line change? Otherwise, it's not enough to for MIT and APL2 licensing and we would still need to include the URL or text somewhere else... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a NuGet package defines its license by expression type and then provides the licenseUrl, the latter is missed during the collection.
This change applies the optional licenseUrl to all licenses processed from the expression, in order not to lose the information.