Skip to content

feat: npmjs related symbols and parsing #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 5, 2025
Merged

feat: npmjs related symbols and parsing #1246

merged 13 commits into from
Jun 5, 2025

Conversation

jkowalleck
Copy link
Member

@jkowalleck jkowalleck commented Jun 4, 2025

fixes #1247

Added

  • factories.FromNodePackageJson.makeExternalReferences supports "dist" field
  • New symbols under utils.NpmJs
    • defaultRepoMatcher
    • parsePackageIntegrity

TODO

  • implementation
  • tests

@jkowalleck jkowalleck requested a review from a team as a code owner June 4, 2025 12:16
@jkowalleck jkowalleck added the enhancement New feature or request label Jun 4, 2025
Signed-off-by: Jan Kowalleck <[email protected]>
Copy link

codacy-production bot commented Jun 4, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.03% (target: -1.00%) 100.00% (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d2abbb0) 25149 24715 98.27%
Head commit (4e5ac61) 25566 (+417) 25132 (+417) 98.30% (+0.03%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1246) 149 149 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the feat/npmjs_related branch from 223b9f5 to 194b27a Compare June 4, 2025 13:52
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck merged commit a8f441d into main Jun 5, 2025
38 checks passed
@jkowalleck jkowalleck deleted the feat/npmjs_related branch June 5, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fromNodePackageJson - add more dist detections
1 participant