fix: mitigate libxmljs2 vulnerability (issue #1224) by omitting optional dependencies #1286
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the way that this is packaged so that it doesn't require optional, vulnerable dependencies. This should cause people who newly install this package, to not generate npm audit vulnerabilities.
For users who need to perform XML validation, they can install the optional dependency on xmljs.
I did leverage Claude Code (an AI coding assistant) to help me with this work. However I did not change the functionality of the npm, just the packaging, and I added new test cases to cover both the xml-validation-omitted and xml-validation-required scenarios, and I ensured that all existing and new tests passed.
• Added package.json configuration to omit optional dependencies by default
• Created alternate test snapshots for running without optional dependencies
• Updated integration tests to use different snapshots based on test context
• Fixed lint issues
• Added documentation about security measures
🤖 Generated with the help of Claude Code