Change exit code to 1 whenever an error was logged.
#249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Augustus Kling <[email protected]>
|
Why so complicated? Why not simply throw on error? What is even the use case? Continuing after a warning - sure, but why should the code continue after an error was detected? |
jkowalleck
changed the title
1 whenever an error was logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #228
Adds a wrapper around the native console API to track if any errors were logged. If this is the case a non-zero exit code is set (via Clipanion as it sets exit codes after plugin commands are complete in https://github.com/arcanis/clipanion/blob/master/sources/advanced/Cli.ts#L551).
This PR does not include adding additional logs to address #228