-
-
Notifications
You must be signed in to change notification settings - Fork 68
Added citation support and test cases. #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.7-dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Steve Springett <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
RFC notice sent on May 1, 2025
Public RFC period ended May 29, 2025 |
@stevespringett i see lacks in the implementation. I'd reject the current version for its unclear implementation. |
…o or process (or both) are required. Added invalid JSON test case. Signed-off-by: Steve Springett <[email protected]>
my remark was clarified. since there is no question left in the spec, this is ready for TC54 vote. i will fix the current merge conflicts, and i will add additional valid/invalid examples according to spec, and might adjust the schemas to detect the invalid cases if possible. PS: |
after reading this spec again, i really do not like it. 👎 the idea of PS: I understand the idea - have something to annotate everything, without the need of adding
Were alternatives considered during the development of this solution? |
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
<xs:element name="process" type="bom:refLinkType" minOccurs="0" maxOccurs="1"> | ||
<xs:annotation> | ||
<xs:documentation> | ||
The `bom-ref` to a process (such as a formula, workflow, task, or step) defined in the `formulation` section that executed or generated the attributed data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per spec, formulations
describe how a component came together.
Describes how a component or service was manufactured or deployed. This is achieved through the use of formulas, workflows, tasks, and steps, which declare the precise steps to reproduce along with the observed formulas describing the steps which transpired in the manufacturing process.
per spec, metadata.tools
list how the BOM came together.
The tool(s) used in the creation, enrichment, and validation of the BOM.
since this feature intents to annotate/detail how the BOM was made, I would expect to reference one of metadata.tools
here, not a formulation.
am i wrong?
TODO/DONE