[DRAFT] refactor: metadata distribution to be an object #653
+44
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Kowalleck <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
|
@prabhu @anthonyharrison what do you think, does this refactor make sense to you? |
Signed-off-by: Jan Kowalleck <[email protected]>
jkowalleck
changed the title
jkowalleck
changed the title
prabhu
reviewed
Jun 16, 2025
| "title": "Distribution", | ||
| "description": "The Traffic Light Protocol (TLP) classification that controls the sharing and distribution of the data that the BOM describes.", | ||
| "$ref": "#/definitions/tlpClassification" | ||
| "distributionConstraints": { |
There was a problem hiding this comment.
How about distributionTerms or sharingPolicies rather than constraints?
prabhu
reviewed
Jun 16, 2025
prabhu
reviewed
Jun 16, 2025
| @@ -559,6 +559,11 @@ enum LicensingTypeEnum { | |||
| } | |||
|
|
|||
| message Metadata { | |||
| message DistributionConstraints { | |||
| // The Traffic Light Protocol (TLP) classification that controls the sharing and distribution of the data that the BOM describes. | |||
| optional TlpClassification tlp = 1; | |||
There was a problem hiding this comment.
tlpClassification or tlpLabel is a bit verbose but could be easy to understand without the need for a help text.
Signed-off-by: Jan Kowalleck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
metadata.distributionto be more verbose in its name, and made it more versatile by converting it to an "object" with "TLP" as a property.caused by #603 (comment)