Skip to content

Add flag to disable markers in runners #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add flag to disable markers in runners #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Builtin/BaseProcesses.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ public void Run()
for (int i = 0, n = _pairs.Length < _markers.Length ? _pairs.Length : _markers.Length; i < n; i++)
{
var pair = _pairs[i];
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].Begin();
#endif
try
{
pair.run.Run();
Expand All @@ -159,7 +161,9 @@ public void Run()
{
pair.cleanup?.RunFinally();
}
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].End();
#endif
}
#else
foreach (var item in Process)
Expand Down
4 changes: 2 additions & 2 deletions src/EcsPipeline.Builder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ public Builder Remove<TSystem>()
#endif
public EcsPipeline Build()
{
#if DEBUG
#if DEBUG && !DRAGONECS_DISABLE_PROFILER_MARKERS
_buildMarker.Begin();
#endif
var it = new LinkedListCountIterator<SystemNode>(_systemNodes, _systemNodesCount, _startIndex);
Expand Down Expand Up @@ -373,7 +373,7 @@ public EcsPipeline Build()
{
item.Declare(pipeline);
}
#if DEBUG
#if DEBUG && !DRAGONECS_DISABLE_PROFILER_MARKERS
_buildMarker.End();
#endif
return pipeline;
Expand Down
4 changes: 2 additions & 2 deletions src/EcsPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ public void Init()
EcsDebug.PrintWarning($"This {nameof(EcsPipeline)} has already been initialized");
return;
}
#if DEBUG
#if DEBUG && !DRAGONECS_DISABLE_PROFILER_MARKERS
_initMarker.Begin();
#endif

Expand All @@ -219,7 +219,7 @@ public void Init()
_isInit = true;

GC.Collect();
#if DEBUG
#if DEBUG && !DRAGONECS_DISABLE_PROFILER_MARKERS
_initMarker.End();
#endif
}
Expand Down
16 changes: 16 additions & 0 deletions src/EcsRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,9 @@ public void Run(Action<TProcess> translationCallback)
CheckCache(translationCallback);
for (int i = 0, n = _process.Length < _markers.Length ? _process.Length : _markers.Length; i < n; i++)
{
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].Begin();
#endif
try
{
translationCallback(_process[i]);
Expand All @@ -214,7 +216,9 @@ public void Run(Action<TProcess> translationCallback)
EcsDebug.PrintError(e);
#endif
}
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].End();
#endif
}
#else
foreach (var item in _process)
Expand Down Expand Up @@ -242,7 +246,9 @@ public void Run<TData>(ActionWithData<TProcess, TData> translationCallback, ref
CheckCache(translationCallback);
for (int i = 0, n = _process.Length < _markers.Length ? _process.Length : _markers.Length; i < n; i++)
{
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].Begin();
#endif
try
{
translationCallback(_process[i], ref data);
Expand All @@ -255,7 +261,9 @@ public void Run<TData>(ActionWithData<TProcess, TData> translationCallback, ref
EcsDebug.PrintError(e);
#endif
}
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].End();
#endif
}
#else
foreach (var item in _process)
Expand Down Expand Up @@ -370,7 +378,9 @@ public void Run(
for (int i = 0, n = _pairs.Length < _markers.Length ? _pairs.Length : _markers.Length; i < n; i++)
{
var pair = _pairs[i];
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].Begin();
#endif
try
{
translationCallback(pair.run);
Expand All @@ -390,7 +400,9 @@ public void Run(
translationFinnalyCallback(pair.runFinally);
}
}
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].End();
#endif
}
#else
foreach (var item in _pairs)
Expand Down Expand Up @@ -426,7 +438,9 @@ public void Run<TData>(
for (int i = 0, n = _pairs.Length < _markers.Length ? _pairs.Length : _markers.Length; i < n; i++)
{
var pair = _pairs[i];
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].Begin();
#endif
try
{
translationCallback(pair.run, ref data);
Expand All @@ -446,7 +460,9 @@ public void Run<TData>(
translationFinnalyCallback(pair.runFinally, ref data);
}
}
#if !DRAGONECS_DISABLE_PROFILER_MARKERS
_markers[i].End();
#endif
}
#else
foreach (var pair in _pairs)
Expand Down