Fixed compilation error #120
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcmtk/dcmdata/include/dcmtk/dcmdata/libi2d/i2d.h:37:24: error: ‘class Image2Dcm’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
37 | class DCMTK_I2D_EXPORT Image2Dcm
| ^~~~~~~~~
|
Thanks Mathieu, closed with a96783a (visible on public master within the next few days). |
michaelonken
added a commit
that referenced
this pull request
Jun 16, 2025
Classes with virtual functions must have their destructor also made virtual. Thanks to Mathieu Malaterre <[email protected]> for the pull request. This closes GitHub pull request #120.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dcmtk/dcmdata/include/dcmtk/dcmdata/libi2d/i2d.h:37:24: error: ‘class Image2Dcm’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor]
37 | class DCMTK_I2D_EXPORT Image2Dcm
| ^~~~~~~~~