Closed
Conversation
Contributor
Author
|
@eichelberg This is inspired by the lines: later in the same function body. Please review, thanks |
malaterre
force-pushed
the
bulkDataURIPrefix
branch
from
3dfba31 to
acaa879
Compare
Function could be extended in client code
malaterre
force-pushed
the
bulkDataURIPrefix
branch
from
acaa879 to
1dfb16b
Compare
Member
|
Merged into DCMTK's testing branch. |
michaelonken
pushed a commit
that referenced
this pull request
Jun 22, 2025
In DcmJsonFormat::writeBulkData(), access the URI prefix for bulk data URIs through the official API method getBulkDataURIPrefix() in order to allow derived classes to override the implementation. Thanks to Mathieu Malaterre <[email protected]> for the pull request. This closes GitHub PR #121.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function could be extended in client code