Skip to content

Rework writeBulkData API #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

malaterre
Copy link
Contributor

Expose the same set of parameters as the caller function writeBinaryAttribute

Expose the same set of parameters as the caller function
writeBinaryAttribute
@malaterre
Copy link
Contributor Author

malaterre commented Jun 18, 2025

@eichelberg sha256 trick is very clever but some other implementation may choose something like :

"00420011" : {
   "BulkDataURI" :
"http://image-manager.acme.corp:1234/dicom-web/1.2.3/series/4.5.6/instances/7.8.9/bulkdata/00420011",
   "vr" : "OB"
},

I believe this is the case for dcm4che. Please consider. Thanks

@eichelberg eichelberg closed this Jun 19, 2025
@eichelberg
Copy link
Member

Merged into DCMTK's testing branch.

michaelonken pushed a commit that referenced this pull request Jun 22, 2025
Now exposing the same set of parameters as the caller function
writeBinaryAttribute.

Thanks to Mathieu Malaterre <[email protected]> for the pull request.

This closes GitHub PR #122.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants