Skip to content

Separated out browser coding guidance from the javascript standard #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ben-sagar
Copy link
Contributor

Following discussion on the Javascript standard, that has now been distilled down to just using Standard JS, so I've moved this guidance into a separate branch.

This PR is to discuss whether we are still happy to have this information in just as guidance.

@ben-sagar ben-sagar requested a review from a team January 7, 2020 16:24
@ben-sagar ben-sagar self-assigned this Jan 7, 2020
@Cruikshanks
Copy link
Member

I still feel it's very general advice, that sometimes dips into specifics. For example

mitigate the risks of XSS and XSI attacks

That's great, but I'd ideally like some examples (or pointers to) of how to do this in clientside JavaScript if we are specifying these. It seems actually to be more an opener to being aware of OWASP and the issues it lists. If that's the case then we should say just that and not get into specifics.

The point about testing. Anyone building a web site whatever the tech should be testing with Browserstack, but also for things like accessibility. Again that seems very general and not specific to client-side JavaScript.

Finally, I'd appreciate a clearer context for statements like "Validate inputs on the client and the server". Does this just apply if you are writing client-side JavaScript? Or to anyone building a web app?

@ben-sagar ben-sagar added the backlog To be looked at later label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog To be looked at later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants