Refactor Supplementary Billing Flags #2647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://eaflood.atlassian.net/browse/WATER-4137 https://eaflood.atlassian.net/browse/WATER-4199 https://eaflood.atlassian.net/browse/WATER-4622 https://eaflood.atlassian.net/browse/WATER-4588 Upon completion of the above two-part tariff supplementary tickets, it was noted that there are now multiple places in the code that handles flagging for pre-sroc supplementary, sroc supplementary and now two-part tariff supplementary. The UI has its own flagging mechanisms as well as the service repo and now our new code in system. To keep things consistent, and easy to maintain it was decided that all the code for flagging a supplementary bill run be consolidated into the system repo. All other flagging mechanisms can be removed meaning there is only 1 place to update and maintain flagging. This PR is a housekeeping task to reduce the code.
… calling service/ now UI calls system directly)
Beckyrose200
force-pushed
the
refactor-flag-for-billing
branch
from
ca32c50
to
e02d1c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eaflood.atlassian.net/browse/WATER-4137
https://eaflood.atlassian.net/browse/WATER-4199
https://eaflood.atlassian.net/browse/WATER-4622
https://eaflood.atlassian.net/browse/WATER-4588
Upon completion of the above two-part tariff supplementary tickets, it was noted that there are now multiple places in the code that handles flagging for pre-sroc supplementary, sroc supplementary and now two-part tariff supplementary. The UI has its own flagging mechanisms as well as the service repo and now our new code in system.
To keep things consistent, and easy to maintain it was decided that all the code for flagging a supplementary bill run be consolidated into the system repo. All other flagging mechanisms can be removed meaning there is only 1 place to update and maintain flagging. This PR is a housekeeping task to reduce the code.