Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Keyword searching #4453

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

WIP: Keyword searching #4453

wants to merge 31 commits into from

Conversation

dcyoung-dev
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Attach PR to Trello card

@dcyoung-dev dcyoung-dev added the deploy_v2 DO NOT USE label Aug 15, 2024
@dcyoung-dev dcyoung-dev marked this pull request as ready for review August 15, 2024 13:50
@dcyoung-dev dcyoung-dev marked this pull request as draft August 15, 2024 13:51
@dcyoung-dev
Copy link
Contributor Author

Find Prototype app
https://find-review-4453.test.teacherservices.cloud/

@dcyoung-dev dcyoung-dev force-pushed the dy-search-spike branch 4 times, most recently from 37bd4fe to f527f3e Compare August 23, 2024 14:11
@dcyoung-dev dcyoung-dev force-pushed the dy-search-spike branch 2 times, most recently from dc03c2b to 67dd52b Compare September 6, 2024 14:28
@dcyoung-dev dcyoung-dev marked this pull request as ready for review September 6, 2024 14:44
@dcyoung-dev dcyoung-dev marked this pull request as draft September 6, 2024 15:02
@avinhurry avinhurry closed this Sep 10, 2024
@avinhurry avinhurry reopened this Sep 10, 2024
@github-actions github-actions bot temporarily deployed to review_aks-4453 September 10, 2024 09:03 Destroyed
@Nitemaeric Nitemaeric added deploy_v2 DO NOT USE and removed deploy_v2 DO NOT USE labels Nov 6, 2024
@Nitemaeric Nitemaeric closed this Nov 6, 2024
@Nitemaeric Nitemaeric reopened this Nov 6, 2024
@Nitemaeric Nitemaeric changed the base branch from main to dd/search-spike-backup November 6, 2024 10:40
@Nitemaeric Nitemaeric changed the base branch from dd/search-spike-backup to main November 6, 2024 10:44
@Nitemaeric
Show nudge after 5th course in results
afa3406 
Only show "not sure which course is right for you" if there are results.
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 13:29 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 14:25 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 14:35 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 15:12 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 15:18 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 14, 2024 15:24 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 10:54 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 10:59 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 11:09 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 11:30 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to review_aks-4453 November 15, 2024 13:46 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kelliedesigner kelliedesigner

@dcyoung-dev dcyoung-dev

Labels
deploy_v2 DO NOT USE spike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcyoung-dev @Nitemaeric @kelliedesigner @avinhurry