Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "All" group attr to new unit_action_type enums #792

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Add "All" group attr to new unit_action_type enums #792

merged 1 commit into from
Aug 3, 2024

Conversation

Bumber64
Copy link
Contributor

@Bumber64 Bumber64 commented Jul 22, 2024

Add enum attrs so all unit_action_type enums are in the All unit_action_type_group.

They may also need attrs for Movement, MovementFeet, Combat, and/or Work (however we decide that).

@myk002
Copy link
Member

myk002 commented Jul 29, 2024

are these types handled by the action timers API in Units.cpp?

@Bumber64
Copy link
Contributor Author

are these types handled by the action timers API in Units.cpp?

Looks like HoldItem, Mount, and Dismount are?

ReleaseItem, LeadAnimal, and StopLeadAnimal return nullptr for getActionTimerPointer. So do Jump, ReleaseTerrain, Parry, and Block, despite already being in the All group.

@myk002
Copy link
Member

myk002 commented Aug 1, 2024

ok, if there are no additional timers to handle, then this looks good to me. will merge after @quietust approves

@myk002
Copy link
Member

myk002 commented Aug 3, 2024

seems ok -- @quietust please tell me if you have any comments

@myk002 myk002 merged commit 65aea3d into DFHack:master Aug 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants