Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update remaining structures for 51.01-beta20 #796

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

quietust
Copy link
Member

This does not include viewscreen_adventure_logst because we don't actually have that screen right now.

Do not merge until we've compared the new size of graphic[st] to what's in the EXE's global table entry for gps.

This does not include viewscreen_adventure_logst because we don't actually
have that screen right now.
Copy link
Contributor

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
graphic linux64 262296 263064 +768
graphic windows64 261472 262240 +768
interface_setst linux64 41336 41592 +256
interface_setst windows64 41336 41592 +256
region_print_datast linux64 400 416 +16
region_print_datast windows64 400 416 +16
viewscreen_worldst linux64 33752 33768 +16
viewscreen_worldst windows64 33720 33736 +16

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@quietust
Copy link
Member Author

[2:33 PM]rome of oxtrot: 40060h in globals
[2:34 PM]rome of oxtrot: found it manually (search for "gps", search for bytes with address of "gps", go forward 16 bytes, parse as long)

...and 0x40060 is 262240, which matches the Windows value in the table above.

@quietust quietust merged commit f2e4527 into DFHack:adv-beta Aug 14, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant