remove lua.h dependency from vtableinterpose.h #5628
Conversation
| void field_error_(lua_State *state, int index, const char* err, const char* mode) | ||
| { | ||
| DFHack::LuaWrapper::field_error(state, index, err, mode); | ||
| } |
There was a problem hiding this comment.
These introduce potential pessimizations by preventing the compiler from inlining these at their call sites. Since at least two of these functions are used in potentially high-velocity code paths, I'm reluctant to approve this without runtime profiling
that said, i just tested dfhack compiled with LTCG and it seems to work on Windows, which would obviate this concern if we can confirm that using LTCG doesn't break dfhack, and someone can figure out how to do the same thing for linux users
| }; | ||
| #endif | ||
|
|
||
| type_identity* lua_touserdata_(lua_State* state); |
There was a problem hiding this comment.
are the trailing underscores necessary? can we not just fully-qualify the names when needed (or would that require changing too many places)?
There was a problem hiding this comment.
These are forwarding functions (intended for DataIdentity only) used by DataIdentity.c so that we can include LuaWrapper.h which in turn includes lua.h in the DataIdentity TU instead of the header.
the real lua_touserdata() takes another argument too.
_wrapper or something similar is another alternative. I wasn't sure what name to give it, hence the underscores.
I don't think they're necessary?
3 participants
may resolve #5517
I believe this does the trick. Just added some wrappers so that
DataIdentity.hdoesn't have to includeLuaWrapper.hwhich in turn includeslua.h.sadly
ninja -d statsdidn't report any measurable difference in build times.