-
Notifications
You must be signed in to change notification settings - Fork 57
Stonesense Info Panel mockup (dont merge) #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
realSquidCoder
wants to merge
35
commits into
DFHack:master
Choose a base branch
from
SquidCoderIndustries:squid-guipanel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Stonesense Info Panel mockup (dont merge) #226
realSquidCoder
wants to merge
35
commits into
DFHack:master
from
SquidCoderIndustries:squid-guipanel
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Maybe should figure out how to use al_do_multiline_text() |
ab9rf
requested changes
Mar 26, 2025
ab9rf
requested changes
Mar 26, 2025
| } | ||
|
|
||
| allCurrentChars += nextChar; // Append the character if it fits | ||
| std::string fitTextToWidth(const std::string input, int width) { |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider using std::string_view input here, not a big change but might eliminate a copy-construct
ab9rf
requested changes
Mar 26, 2025
Collaborator
Author
|
can i get another look thru to see what i missed or forgot? |
ab9rf
reviewed
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just meant to show off what I'm working on in a way that people can more easily discover.