Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated classes and functions #1764

Closed
wants to merge 97 commits into from
Closed

Remove deprecated classes and functions #1764

wants to merge 97 commits into from

Conversation

BDoignies
Copy link
Contributor

PR Description

Remove deprecated classes and functions.

  • Questionable changes may be made to the LocalConvolutionNormalVectorEstimator test codes. See the relevant commit message for more details.
  • Some tests might be remove as the class they were used to test no longer exists (although there is a replacement)
  • Shapes::addNorm1Ball and Shapes::addNorm2Ball are marked as deprecated but this seems inconsistent because 'Shapes::removeNorm1Ball' and 'Shapes::removeNorm2Ball' are not. Furthermore, they are still widely used. I did not remove them but I can if anyone you confirm they should be removed.

Checklist

  • [?] Unit-test of your feature with Catch.
  • Doxygen documentation of the code completed (classes, methods, types, members...)
  • [?] Documentation module page added or updated.
  • New entry in the ChangeLog.md added.
  • No warning raised in Debug mode.
  • All continuous integration tests pass (Github Actions)

dcoeurjo and others added 30 commits December 24, 2024 10:15
@dcoeurjo
BUILD TESTS and BUILD EXAMPLES
67da915
@dcoeurjo
WITH_OPENMP -> DGTAL_WITH_OPENMP
d6cd341
@dcoeurjo
WITH_CAIRO -> DGTAL_WITH_CAIRO
e881290
@dcoeurjo
WITH_LIBIGLM -> DGTAL_WITH_LIBIGL
bcf12b7
@dcoeurjo
Init 2.0 release
70a4e01
@dcoeurjo
Merge branch 'main2.0' into renamingCmakeVars
8c447c8
@dcoeurjo
ITK
486a191
@dcoeurjo
ITK (CI)
38821dc
@dcoeurjo
HDF5 (CI)
6583dc4
@dcoeurjo
CGAL FFTW(CI)
37cb280
@dcoeurjo
CGAL FFTW(CI)
143087c
@dcoeurjo
CGAL FFTW(CI)
127a5b1
@dcoeurjo
fixing actions
094d5d8
@dcoeurjo
Removing unnecessary includes (detected using https://github.com/incl…
9de4662 
…ude-what-you-use/include-what-you-use)
@BDoignies
Update CMake version
fc6fba2
@BDoignies
C++20 + start to remove cpp files
535f7b0
@BDoignies
Remove .cpp files in base
aa8d6fc
@BDoignies
Fix compilation (C++20 allocator + forgot inline)
a8e8f99
@BDoignies
WIP new CMake
a066a0a
@BDoignies
Move dependancies to deps/ folder
7531e01
@BDoignies
C++20 enum deprecation
16f0a0a
@BDoignies
Added example, removes unnecessary global functions
9f3069a
@BDoignies
Added back .in files
c3aa17c
@BDoignies
New CMake managment
04f7926
@BDoignies
Remove legacy CMakeLists
24be192
@BDoignies
Reinstate doxygen
e355433
@BDoignies
Fixs
058b4c9
@dcoeurjo
Activate github actions for main2.0
238cb3e
@dcoeurjo
Color does not include Common.h anymore
3be5942 
Fixing BasicTypes with std uint32_t instead of boost::uint32_t
@dcoeurjo @BDoignies
Merging dgtal variable names (tbc)
139612c
BDoignies and others added 27 commits February 7, 2025 15:02
@BDoignies
Remove comment for unused variable
c3163ee
@dcoeurjo
Conflicts
62169e2
@BDoignies
Updated documentation and changelog
482fab9
@BDoignies
Fix missing typename
77b8f27
@BDoignies
Fix DGTalConfig.cmake exported variables
1475de5
@BDoignies
ReAdd compile definition removed in DGtal-team#1754 (necessary for DG…
d994142 
…talTools)
@BDoignies
New workflow file for PR on main2.0
b83a465
@BDoignies
Fix indents of new workflow style
9a10cdc
@BDoignies
Fix order of new workflow
64d1bbb
@BDoignies
Debug File to see why CMake does not find modules
6b5a9d2
@BDoignies
Make DGTalTargets.cmake available to DGTalConfig.cmake in build direc…
219308c 
…tory
@BDoignies
Add namespace to export
34ec924
@BDoignies
Filter ITK include paths
e07c0c2
@BDoignies
Cleaning workflow file
41a026b
@BDoignies
Move python tests to base action file (not same requirements)
8ca7fa8
@BDoignies
Activate tests and other system build
7b3419c
@BDoignies
Forgot to run tests
8ffe538
@BDoignies
Remove python config
01e77aa
@BDoignies
Fix codacity report
efb5efe
@dcoeurjo
Update .github/workflows/build-PR2.0.yml
4a5dc60
@dcoeurjo
Merge pull request DGtal-team#1757 from BDoignies/CMakev2
48e76e4 
CMake V2 + Cpp20 + (Almost) Header only
@BDoignies
Remove safe-to delete content
b2592fd
@BDoignies
remove GridCurve::initFromVector
d133c2b
@BDoignies
Fix Viewer3D material can not be assigned
9b15edc
@BDoignies
Remove deprecated LocalConvolutionNormalVectorEstimator
ffa58d9 
List of changes:
* Remove "LocalConvolutionNormalVectorEstimator" and "BasicConvolutionWeights"
* Tests using the class now uses the replacement "LocalEstomatorFromSurfelFunctorAdapter"
* Added an overload to eval() function required by some tests
* Added a function evalAll required by some tests
* Remove subtype DigitalSurfaceEmbedderWithNormalVectorEstimator::NVESurface (it was not used anywhere else) and corresponding assert.
* Remove concept check CNormalVectorEstimator as it does not correspond to the new method and was only used at a single place.
@BDoignies
Remove function marked as deprecated (but not in header)
c03c919
@BDoignies
Updated documentation to remove reference to deprecated functions and…
e8bd77c 
… classes.
@BDoignies BDoignies requested a review from dcoeurjo March 3, 2025 17:11
@BDoignies BDoignies closed this Mar 3, 2025
@BDoignies
Copy link
Contributor Author

Sorry wrong merge destination...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoeurjo dcoeurjo Awaiting requested review from dcoeurjo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BDoignies @dcoeurjo @kerautret