Skip to content

Replaced inline div to use carbon grid in order component #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

peach280
Copy link
Contributor

@peach280 peach280 commented Apr 16, 2025

Pull Requests Requirements

  • The PR title includes a brief description of the work done, including the
    Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design
    documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

This PR deals with replacing inline div with carbon grid in add sample and additional questions component.
I made same pr as they both are inside order component.
The pages are working fine in add order as well as edit order page.

Screenshots

Add Sample(Add order)
Desktop
before:

Screenshot 2025-04-16 075710

after:

Screenshot 2025-04-16 075228

Mobile:
before:
Screenshot 2025-04-16 075545
after:
Screenshot 2025-04-16 075728

Order Entry Additional Questions
Add order:

Desktop
before:
Screenshot 2025-04-18 125942

after:
Screenshot 2025-04-18 130035

Mobile:
before:
image
after:
Screenshot 2025-04-18 130244

Edit order:
Desktop:
before:
Screenshot 2025-04-18 130352
after:
Screenshot 2025-04-18 130447

Mobile:
before:
Screenshot 2025-04-16 075522
after:
Screenshot 2025-04-18 121053

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants