Fix issue WebApiContrib#176. Old service provider should be restored …

…to the HttpContext after the branch scope is finished.
DJackman123 · May 24, 2019 · 6bb1e9c · 6bb1e9c
1 parent cfb6dee
commit 6bb1e9c
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 0 deletions.
diff --git a/src/WebApiContrib.Core/ParallelApplicationPipelinesExtensions.cs b/src/WebApiContrib.Core/ParallelApplicationPipelinesExtensions.cs
@@ -55,6 +55,7 @@ public static IApplicationBuilder UseBranchWithServices(this IApplicationBuilder
 
             branchBuilder.Use(async (context, next) =>
             {
+                var oldServiceProvider = context.RequestServices;
                 using (var scope = factory.CreateScope())
                 {
                     context.RequestServices = scope.ServiceProvider;
@@ -67,6 +68,7 @@ public static IApplicationBuilder UseBranchWithServices(this IApplicationBuilder
 
                     await next();
                 }
+                context.RequestServices = oldServiceProvider;
             });
 
             appBuilderConfiguration(branchBuilder);

diff --git a/tests/WebApiContrib.Core.Tests/ParallelPipelinesStartup.cs b/tests/WebApiContrib.Core.Tests/ParallelPipelinesStartup.cs
@@ -3,6 +3,7 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.AspNetCore.Http;
+using Microsoft.Extensions.Logging;
 
 namespace WebApiContrib.Core.Tests
 {
@@ -87,6 +88,22 @@ public void Configure(IApplicationBuilder app)
                     await c.Response.WriteAsync(service.Hi());
                 });
             });
+
+            // Add middleware before the next branch to verify state of the context coming out of the branch
+            app.Use(async (c, next) =>
+            {
+                // Call into the branch
+                await next();
+
+                // Verify the service provider is working
+                var service = c.RequestServices.GetService<ILogger>();
+            });
+
+            app.UseBranchWithServices("/baz", s =>
+            {
+            }, a =>
+            {
+            });
         }
     }
 }
diff --git a/tests/WebApiContrib.Core.Tests/ParallelPipelinesTests.cs b/tests/WebApiContrib.Core.Tests/ParallelPipelinesTests.cs
@@ -50,5 +50,14 @@ public async Task CanReachBranchWithMultipleEntryPoints(string path)
 
             Assert.Equal($"hi {path.Substring(0, path.Length-1)}", stringResult);
         }
+
+        [Fact]
+        public async Task PipelineBeforeTheBranchStillHasWorkingServiceProvider()
+        {
+            var client = _server.CreateClient();
+
+            var request = new HttpRequestMessage(HttpMethod.Get, $"/baz");
+            await client.SendAsync(request);
+        }
     }
 }