Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hyperparameter tuning for RecurrentPPO #415

Merged
merged 9 commits into from
Oct 28, 2023

Conversation

technocrat13
Copy link
Contributor

@technocrat13 technocrat13 commented Oct 23, 2023

Hyperparameter tuning for RecurrentPPO was non-existent as hyperparams_opt.py did not accept 'ppo_lstm' as a valid argument

Description

  • Extended sample_ppo_params() to be called by sample_ppo_lstm_params(), trail is then updated with some lstm specific hyperparams, and "policy_kwargs" is updated
  • Added "tiny" to sample_ppo_params() to support smaller neural nets for the LSTM (solution 2 in issue #409)

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format (required)
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)

Note: we are using a maximum length of 127 characters per line

@araffin araffin self-requested a review October 26, 2023 12:30
Copy link
Member

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks =)

Could you please update the changelog?
as you use master branch (protected by default), I couldn't push the changes...

@technocrat13
Copy link
Contributor Author

updated changelog, let me know if anything else is required, I can add you as a contributor, seems a little late to create a branch (I will keep this in mind next time)

@araffin araffin merged commit e98c00e into DLR-RM:master Oct 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ppo_lstm not implemented in hyperparams_opt.py
2 participants