Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Policies with layer normalization #1069

Closed
2 tasks done
astrofinix opened this issue Sep 18, 2022 · 1 comment · Fixed by #1975
Closed
2 tasks done

[Question] Policies with layer normalization #1069

astrofinix opened this issue Sep 18, 2022 · 1 comment · Fixed by #1975
Labels
enhancement New feature or request question Further information is requested

Comments

@astrofinix
Copy link

Question

Will there be there be future plans to implement layer normalized policies (MlpLnLstmPolicy, CnnLnLstmPolicy)?

Checklist

  • I have read the documentation (required)
  • I have checked that there is no similar issue in the repo (required)
@astrofinix astrofinix added the question Further information is requested label Sep 18, 2022
@araffin
Copy link
Member

araffin commented Sep 19, 2022

Hello,
Layer normalization was originally made for using parameter noise, so they were removed in SB3 (cf. docs).
However, recently, there have some works that do use LN and dropout, so I plan to add those as options in the building blocs: #1036

In the meantime, you can always define custom policies (cf. doc again) and for LSTM policies, only RecurrentPPO from our contrib repo support them.

@araffin araffin changed the title [Question] question title [Question] Policies with layer normalization Sep 19, 2022
@araffin araffin added the enhancement New feature or request label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants