Add support for pre and post linear modules in create_mlp
#1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
qgallouedec
approved these changes
Jul 20, 2024
| else: | ||
| modules = [] | ||
| for module in pre_linear_modules: | ||
| modules.append(module(input_dim)) |
Collaborator
There was a problem hiding this comment.
Is the input dim the same for all modules?
Collaborator
There was a problem hiding this comment.
I think I get it. It only allows modules that have the same input/output dimension.
Member
Author
There was a problem hiding this comment.
maybe it is clearer with this test:
stable-baselines3/tests/test_custom_policy.py
Lines 102 to 104 in 3b84f71
shall I add a comment to avoid confusion?
Collaborator
There was a problem hiding this comment.
Yes! I've also suggested a new documentation: https://github.com/DLR-RM/stable-baselines3/pull/1975/files#r1686213647
qgallouedec
reviewed
Jul 22, 2024
Co-authored-by: Quentin Gallouédec <[email protected]>
friedeggs
pushed a commit
to friedeggs/stable-baselines3
that referenced
this pull request
Jul 22, 2024
) * Add support for pre and post linear modules in `create_mlp` * Disable mypy for python 3.8 * Reformat toml file * Update docstring Co-authored-by: Quentin Gallouédec <[email protected]> * Add some comments --------- Co-authored-by: Quentin Gallouédec <[email protected]>
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1069 and #1036 and Stable-Baselines-Team/stable-baselines3-contrib#243 (DroQ and CrossQ)
I also added missing tests for
create_mlp.Motivation and Context
closes #1069
Types of changes
Checklist
make format(required)make check-codestyleandmake lint(required)make pytestandmake typeboth pass. (required)make doc(required)Note: You can run most of the checks using
make commit-checks.Note: we are using a maximum length of 127 characters per line