Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precommit config yaml and fix typos automatically #1979

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cschindlbeck
Copy link
Contributor

Description

Add a pre-commit-config yaml for the pre-commit message, fix its typos accordingly

There are two open points

Motivation and Context

Automatically check codespell in pre-commit hooks, i.e. every time you commit

Checklist

  • Adapt README.md
  • Add install/pre-commit install to Makefile?

@araffin
Copy link
Member

araffin commented Jul 29, 2024

Hello,
thanks for the PR, but please only keep the typo fixes changes for now.

@cschindlbeck
Copy link
Contributor Author

Hello, thanks for the PR, but please only keep the typo fixes changes for now.

I have split the typos from this PR to this #1981

However, i would strongly recommend to enforce spellcheck and other checks as proposed in this PR in oder to avoid playing catch-up and get in before such things occur

@cschindlbeck cschindlbeck force-pushed the add-precommit-config-yaml branch from 70999c7 to bd3c0c6 Compare July 29, 2024 08:46
@cschindlbeck
Copy link
Contributor Author

Rebased on top of typo fixes

@cschindlbeck cschindlbeck reopened this Jul 29, 2024
@cschindlbeck cschindlbeck force-pushed the add-precommit-config-yaml branch from 8eb5b55 to a4c8676 Compare August 13, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants