start value of Discrete spaces #2054
Open
+136
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the missing applying of start value of Discrete Space
The start value of "spaces.Discrete(3, start=-1)" has no effect and does not shift the space to given start value, even tough there are examples in the Discrete class like: observation_space = Discrete(3, start=-1, seed=42) # {-1, 0, 1}
All Discrete Spaces start currently at zero.
Motivation and Context
This is a bug-fix relating to #2052, #913, #1295, #1378
Types of changes
The start value of spaces.Discrete is added to the actions to properly shift space
Reason for this position is, its the same position, the final scaling of spaces.Box happen. spaces.Discrete was never handled
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass. (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line