simplify GPU detection in docker launch script #2064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize Docker GPU arguments and remove legacy checks
Description
Updated the docker launch script to remove legacy nvidia-docker2 checks and standardize on modern GPU arguments. This simplifies the codebase by removing conditional logic for outdated Docker versions and ensures consistent GPU handling across environments.
Motivation and Context
The script contained a TODO comment indicating to wait until new-style GPU args were widely adopted (estimated 2021). Since we're in 2024 and Docker's native GPU support (introduced in 19.03) is now standard, we can safely remove the legacy compatibility code, making the script cleaner and more maintainable.
Types of changes
Checklist
make format
(required)make check-codestyle
andmake lint
(required)make pytest
andmake type
both pass (required)make doc
(required)Note: You can run most of the checks using
make commit-checks
.Note: we are using a maximum length of 127 characters per line