declare proc_dir earlier and resolve exact proc_dir
#1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Riolku
force-pushed
the
declare-proc-dir
branch
from
3d15da9
to
89160b5
Compare
|
ok to test |
We can declare the proc directory earlier in the code and use it. We intentionally add a trailing slash on line 352, in case for instance, the process PID is 123 and they request /proc/12345. Finally, we add a check for the literal directory /proc/getpid()
Riolku
force-pushed
the
declare-proc-dir
branch
from
89160b5
to
2d7da9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can declare the proc directory earlier in the code and use it. We intentionally add a trailing slash on line 352, in case for instance, the process PID is 123 and they request /proc/12345. Finally, we add a check for the literal directory /proc/getpid()