Allow Requester to input opaque data for finish and psk_finish #3486
+121
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/library/spdm_requester_lib.h
Outdated
| * Opaque data should be less than 1024 bytes. | ||
| * On output, the size of the opaque data. | ||
| */ | ||
| libspdm_return_t libspdm_start_session_ex_part2(void *spdm_context, bool use_psk, |
Contributor
There was a problem hiding this comment.
use_pskslot_idreq_slot_id_param
should be stored in the session_info context and removed from the API.
Comment on lines
596
to
599
| * @param requester_opaque_data A buffer to hold the requester opaque data, if not NULL. | ||
| * If not NULL, this function will not generate any opaque data, | ||
| * including secured message versions. | ||
| * @param requester_opaque_data_size The size of the opaque data, if requester_opaque_data is not NULL. | ||
| * @param responder_opaque_data A buffer to hold the responder opaque data, if not NULL. | ||
| * @param responder_opaque_data_size On input, the size of the opaque data buffer. | ||
| * Opaque data should be less than 1024 bytes. | ||
| * On output, the size of the opaque data. |
Contributor
There was a problem hiding this comment.
These parameters are only used for SPDM 1.4 and later.
fix DMTF#3402 Signed-off-by: Aaron Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3402