Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT/seminar6] 필수과제 #13

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

[FEAT/seminar6] 필수과제 #13

wants to merge 6 commits into from

Conversation

emjayMJkim
Copy link
Member

✍️ Work Description

  • ID/비밀번호 조건 생성
  • ID/비밀번호 생성조건에 맞지 않을 시 회원가입 버튼 비활성화
  • 조건과 맞지 않는 경우 경고문구 띄우기

📸 ScreenShot

seminar6.mp4

🍀 Issues

✔️ PR point

Copy link
Member

@Jokwanhee Jokwanhee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로그인 처리를 데이터 바인딩으로 진행하니 코드가 깔끔합니다! 저도 한 번 적용해봐야겠어요~ 고생하셨습니다 !!

@@ -23,18 +25,29 @@ class SignUpViewModel @Inject constructor(
private val _signUpEnabled = MutableLiveData<Boolean>()
val signUpEnabled: LiveData<Boolean> = _signUpEnabled

val checkBtnEnabled = MediatorLiveData<Boolean>().apply {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediatorLiveData 는 처음 보네요.. 여러 개의 LiveData를 결합해서 관리한다... 좋은 정보 얻고갑니다

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediatorLiveData 사용 너무 좋아요~!!

Copy link

@yeonjeen yeonjeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어용~ 항상 깔끔한 코드👍🏻👍🏻 많이 배우고 갑니당!!

checkUserNameValid()
checkPassWordValid()
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 함수를 또 묶어서 사용하는 건 생각도 못하고 따로 따로 함수만 만들어놨는데..! 저도 한 번 이렇게 해봐야겠어용!!

Copy link
Member

@kez-lab kez-lab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6주차 과제 고생하셨습니다~!!

Comment on lines +37 to +42
val currentFocus = currentFocus
if (currentFocus is EditText) {
currentFocus.clearFocus()
val inputMethodManager = getSystemService(INPUT_METHOD_SERVICE) as InputMethodManager
inputMethodManager.hideSoftInputFromWindow(currentFocus.getWindowToken(), 0)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 👍

@@ -23,18 +25,29 @@ class SignUpViewModel @Inject constructor(
private val _signUpEnabled = MutableLiveData<Boolean>()
val signUpEnabled: LiveData<Boolean> = _signUpEnabled

val checkBtnEnabled = MediatorLiveData<Boolean>().apply {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MediatorLiveData 사용 너무 좋아요~!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[6주차] 필수과제
4 participants