Skip to content

m_ephemerisTime should be double #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Conversation

oleg-alexandrov
Copy link
Collaborator

The value of ephemeris time is in double precision, both in ISIS, ALE, and in USGSCSM, except for this one place, where it is cast to int. The effect is that a timestamp is saved as:

"m_ephemerisTime": 717716358.0,

instead of a correct value such as:

"m_ephemerisTime": 717716358.2862071,

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@acpaquette acpaquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-alexandrov Looks great! Could this get a changelog entry?

@oleg-alexandrov
Copy link
Collaborator Author

Changelog entry added.

@acpaquette acpaquette merged commit ed7f1fe into DOI-USGS:main May 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants