Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip NavigableString in HTML parsing #495

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

higuhigu-lb
Copy link

This PR skips NavigableString elements during HTML parsing to avoid unwanted error.

Issue resolved by this Pull Request:
Resolves #463

Checklist:

  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.
  • Tests have been added, if necessary.

Copy link

mergify bot commented Dec 3, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@higuhigu-lb higuhigu-lb changed the title Skip NavigableString in HTML parsing fix: Skip NavigableString in HTML parsing Dec 3, 2024
@dolfim-ibm
Copy link
Contributor

For reference, here is an example of NavigableString from the docs.

@dolfim-ibm
Copy link
Contributor

@higuhigu-lb thanks for your first contribution. Please note that according to our contributing guidelines, we require sign-off commits.

You can update your PR with the following command

git rebase HEAD~1 --signoff

@higuhigu-lb
Copy link
Author

@dolfim-ibm

Thank you for your helpful advice.
I have updated the commit accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why is an HTML conversion error skipped?
2 participants