-
Notifications
You must be signed in to change notification settings - Fork 478
Adding all missing french translations #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This commit is adding translations for all parameters that were tagged "// TODO New key - Add a translation" in fr.json5 file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the missing French translations in this PR have been checked and verified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pilasou : Overall this looks good, but the fr.json5
file is throwing lint errors because of invalid formatting. I've noted the line that is throwing the error inline below.
src/assets/i18n/fr.json5
Outdated
// TODO New key - Add a translation | ||
"browse.startsWith": ", starting with {{ startsWith }}", | ||
// "browse.startsWith": ": "starting with {{ startsWith }}", | ||
"browse.startsWith": ": "Commencant par {{ startsWith }}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is throwing the lint errors because it's invalid. There's an extra quote ("
) before "Commencant" that shouldn't be there.
It also looks like you accidentally changed the example text as well in the line above this, as you've changed the comma into a colon.
The correct both issues, I think this should be:
// "browse.startsWith": ", starting with {{ startsWith }}",
"browse.startsWith": ", Commencant par {{ startsWith }}",
Hi @tdonohue hi @nimabehforouz thanks for the review. I have committed an update correcting the errors and duplicates you identified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentionned above by Tim, there's just an extra ": on the line 1636. Must be:
"browse.startsWith": ", commencant par {{ startsWith }}",
@tdonohue I think Pierre is out of office this week. I can do a final validation of the file and apply the changes to merge the PR once I have the write access.
References
Description
This commit is adding translations for all parameters that were tagged "// TODO New key - Add a translation" in fr.json5 file.