Skip to content

Adding all missing french translations #4563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pilasou
Copy link
Contributor

@pilasou pilasou commented Jul 21, 2025

References

Description

This commit is adding translations for all parameters that were tagged "// TODO New key - Add a translation" in fr.json5 file.

This commit is adding translations for all parameters that were tagged "// TODO New key - Add a translation" in fr.json5 file.
Copy link
Contributor

@nimabehforouz nimabehforouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the missing French translations in this PR have been checked and verified.

Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilasou : Overall this looks good, but the fr.json5 file is throwing lint errors because of invalid formatting. I've noted the line that is throwing the error inline below.

// TODO New key - Add a translation
"browse.startsWith": ", starting with {{ startsWith }}",
// "browse.startsWith": ": "starting with {{ startsWith }}",
"browse.startsWith": ": "Commencant par {{ startsWith }}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is throwing the lint errors because it's invalid. There's an extra quote (") before "Commencant" that shouldn't be there.

It also looks like you accidentally changed the example text as well in the line above this, as you've changed the comma into a colon.

The correct both issues, I think this should be:

// "browse.startsWith": ", starting with {{ startsWith }}",
"browse.startsWith": ", Commencant par {{ startsWith }}",

@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge labels Jul 22, 2025
@tdonohue tdonohue moved this to 👀 Under Review in DSpace 10.0 Release Jul 22, 2025
@tdonohue tdonohue added this to the 10.0 milestone Jul 22, 2025
@tdonohue tdonohue added the port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release label Jul 22, 2025
@pilasou
Copy link
Contributor Author

pilasou commented Jul 22, 2025

Hi @tdonohue hi @nimabehforouz thanks for the review. I have committed an update correcting the errors and duplicates you identified.

Copy link
Contributor

@nimabehforouz nimabehforouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentionned above by Tim, there's just an extra ": on the line 1636. Must be:
"browse.startsWith": ", commencant par {{ startsWith }}",
@tdonohue I think Pierre is out of office this week. I can do a final validation of the file and apply the changes to merge the PR once I have the write access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release
Projects
Status: 👀 Under Review
Development

Successfully merging this pull request may close these issues.

Tackling all missing language parameters in the fr.json5 file.
3 participants