-
Notifications
You must be signed in to change notification settings - Fork 502
ORCID iDs should be displayed according to ORCID's Display Guidelines #4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… in the person item page
…at it redirects to the orcid website (item view)
…item page the full url with icon that redirects to the orcid page
… id and the icon instead of the full url
nwoodward
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sondissimo! I tested this PR, as well as the backend PR (DSpace/DSpace#11432), and together they work really well. I now see the clickable ORCiD icon on the person and publication pages.
I have one question about the ORCiD link on the person page. The entire red box is clickable for me, but it would be better if only the person's name and the ORCiD icon were clickable. Can you make that change?
|
Hi @Sondissimo, |
References
Add references/links to any related issues or PRs.
Description
Implemented clickable orcid icon and uuid in person item page that redirects to the orcid website person profile
Now the little orcid icon next to the person in item view redirects to orcid website person profile
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Test with the rest counterpart: DSpace/DSpace#11432
List of changes in this PR:


Created new component to show uuid with orcid icon in the person page if it has orcid, with redirect to the orcid website and lands on the person page
updated icon in the related items where the author has orcid and now it redirects to the orcid website and lands on the author page
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Test the pr with the rest counterpart, to test firstly go to the page of a person that has orcid, check if the orcid uuid with the icon redirects you to the orcid website on the person page
Then go on an item where the author has orcid and when the little orcid icon next to the person is shown click it and expect it to redirect onto the orcid website on the author page
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the https://github.com/DSpace/DSpace/pull/11432checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.