Skip to content

Conversation

@Sondissimo
Copy link
Contributor

@Sondissimo Sondissimo commented Oct 8, 2025

References

Add references/links to any related issues or PRs.

Description

Implemented clickable orcid icon and uuid in person item page that redirects to the orcid website person profile
Now the little orcid icon next to the person in item view redirects to orcid website person profile

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Test with the rest counterpart: DSpace/DSpace#11432

List of changes in this PR:
Created new component to show uuid with orcid icon in the person page if it has orcid, with redirect to the orcid website and lands on the person page
image
updated icon in the related items where the author has orcid and now it redirects to the orcid website and lands on the author page
image

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Test the pr with the rest counterpart, to test firstly go to the page of a person that has orcid, check if the orcid uuid with the icon redirects you to the orcid website on the person page
Then go on an item where the author has orcid and when the little orcid icon next to the person is shown click it and expect it to redirect onto the orcid website on the author page

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the https://github.com/DSpace/DSpace/pull/11432checklist, don't hesitate to ask. We're here to help!

  • [x ] My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • [x ] My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • [x ] My PR passes ESLint validation using npm run lint
  • [x ] My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • [x ] My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • [x ] My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • [x ] My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • [x ] My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • [x ] My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • [x ] If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • [x ] If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • [x ] If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue changed the title Task/main/duracom 393 aligned ORCID iDs should be displayed according to ORCID's Display Guidelines Oct 8, 2025
@tdonohue tdonohue added integration: ORCID Related to integration with ORCID identifier system bug port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release labels Oct 8, 2025
@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Oct 8, 2025
Copy link
Contributor

@nwoodward nwoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Sondissimo! I tested this PR, as well as the backend PR (DSpace/DSpace#11432), and together they work really well. I now see the clickable ORCiD icon on the person and publication pages.

I have one question about the ORCiD link on the person page. The entire red box is clickable for me, but it would be better if only the person's name and the ORCiD icon were clickable. Can you make that change?

Image

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👀 Under Review in DSpace 10.0 Release Nov 7, 2025
@github-actions
Copy link

Hi @Sondissimo,
Conflicts have been detected against the base branch.
Please resolve these conflicts as soon as you can. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug integration: ORCID Related to integration with ORCID identifier system merge conflict port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release port to dspace-9_x This PR needs to be ported to `dspace-9_x` branch for next bug-fix release

Projects

Status: 👀 Under Review

Development

Successfully merging this pull request may close these issues.

ORCID iDs should be displayed according to ORCID's Display Guidelines

3 participants