-
Notifications
You must be signed in to change notification settings - Fork 15
Feature/match score for pr #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…tes tree) and the true particle index (from the True Tree)
|
Note that this depends on DUNE/duneanaobj#57 |
noeroy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with the couple of things i've noted.
I'm just not sure why are we defining two matching functions for ndlar and TMS instead of adding all of that work to the existing framework.
Another thing to add will be the proper setup when duneanaobj will be updated and published.
chenel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an overall question/concern here. It looks like this method is directly pulling objects out of the TMS reco file. I think this is likely going to duplicate effort, since the TMSRecoBranchFiller will be doing the same thing. Is there a reason you decided to implement it this way, rather than using the TMS tracks pulled out by the TMSRecoBranchFiller and already put into the StandardRecord? If there isn't a good reason I would heavily prefer using the StandardRecord variants, because otherwise we will have to maintain the TMS interface in two places.
…mpute_match_scores functions for it to call
|
While this PR seems generally good and sane (some TMS-side stuff notwithstanding), I think the ndcaf_setup.sh will require some editing for this to work for users, at least changing the duneanaobj version. (v03_11_00 available on UPS). I do want to make sure this builds and runs before approving. |
This adds a more sophisticated track matching algorithm to ND CAFMaker, which matches tracks between LAr (Pandora or SPINE tracks) and TMS and then creates joint tracks out of the successful matches. Track matching is unique (will never match one track in one detector to multiple tracks in the other detector), has a customizable cutoff (fCut) in Params.h that prevents overmatching, and takes into consideration the projected x and y differences between tracks, angles between tracks, and, optionally, the time difference between when the tracks are created. NOTE: while track matching ought to perform much better when time is included, it is not currently functional. You should run the track matcher in its default configuration, with the useTime parameter set to false, until time-based matching is patched.