Feature/ingratta add beam quality info #109
Conversation
chenel
left a comment
chenel
left a comment
There was a problem hiding this comment.
I don't have any insight into the IF Beam DB itself (hopefully @sindhu-ku can comment on the implementation here), but before we can merge this PR, you'll need to git rm all the .o files that are included in this PR. We don't need intermediate build files in the repository 😄
|
Oooops. This is when you push the changes late afternoon before going home 🫠 |
noeroy
left a comment
noeroy
left a comment
There was a problem hiding this comment.
Nice update, I believe the most important comment is the one to properly link to the new duneanaobj when it will be merged + published in the setup script.
Otherwise, it's a couple of cosmetic comment and a proposal to use a map to link the device name to the beamInfo in the IFBeam.cxx, I'm fine if you decide not to do it though.
| caf.sr.beam.verticalposTGT = verticalposTGT; | ||
| caf.sr.beam.verticalintTGT = verticalintTGT; | ||
| caf.sr.beam.verticalpos121 = verticalpos121; | ||
| caf.sr.beam.multiwireInfo = multiwireInfo; |
There was a problem hiding this comment.
That will need PR DUNE/duneanaobj#60 to be merged and the new version of duneanaobj published + linked to the setup script ndcaf_setup.sh
| trig.triggerTime_s = m_unixTime; | ||
| // unix_time_usec ticks (microseconds) converted to nanoseconds | ||
| trig.triggerTime_ns = m_unixTimeUsec * 1000; | ||
| // trig.triggerTime_ns = m_unixTimeUsec * 1000; |
There was a problem hiding this comment.
Do we need the previous statement to stay commented?
|
thanks for cleaning things up. Once Noe's comments above are resolved, I think you're good to merge. |
|
Good for me, as soon as we get the duneanaobj request DUNE/duneanaobj#60 merged and built + the setup script pointing to that build, we should be fine |
Some beam-related info to evaluate the beam quality for a given spill is missing in the output CAF file (this was marked a while ago as a TODO in a comment here -> #https://github.com/DUNE/ND_CAFMaker/blob/972f11bc5b69ea1f595e14ed16e09162f512011e/src/beam/IFBeam.cxx )
The current code retrieves only the beam POT from the database, and in this PR I added the horn current, horn polarity, beam position, and intensity info to the output CAF.
The code compiles and has been tested on a few minutes' worth of 2x2 data from last year. See docDB for more details: DUNE-doc-35166-v1