Open
Conversation
Member
|
Current setup_fnal_security is broken, so approving this. We may have to back-port to older releases? |
tomjunk
previously approved these changes
May 27, 2025
tomjunk
reviewed
May 27, 2025
|
|
||
| # get a new token if there is no existing one | ||
| if [[ ! -f $BEARER_TOKEN_FILE ]]; then | ||
| htgettoken -a htvaultprod.fnal.gov -i nova |
Member
There was a problem hiding this comment.
@vhewes Please review "nova" here. Is this intentional?
Member
Member
Author
|
it is, thank you for the reminder. this script is based on a similar script for NOvA, which continued to evolve for a while after the transition to tokens, so i decided to wait until development settled on that script before propagating further changes to DUNE. i think that script has settled now though, so i'll port the changes over and update this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update
setup_fnal_securityto get and check tokens instead of X509 proxy certificates